This repository was archived by the owner on Sep 9, 2024. It is now read-only.
feat: remove required name in media_library config#234
Merged
KaneFreeman merged 1 commit intoStaticJsCMS:mainfrom Dec 14, 2022
Merged
feat: remove required name in media_library config#234KaneFreeman merged 1 commit intoStaticJsCMS:mainfrom
KaneFreeman merged 1 commit intoStaticJsCMS:mainfrom
Conversation
name is only required to configure an external media library, but the media_library config can be used without a name to configure the max file size for example. See in `core/src/mediaLibrary.ts` the `isExternalMediaLibraryConfig` function.
✅ Deploy Preview for staticjscms canceled.
|
Contributor
Author
|
Do you have an idea how I can build the dist js file so I can test this? edit: oops I forgot to |
KaneFreeman
approved these changes
Dec 14, 2022
KaneFreeman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name is only required to configure an external media library, but the media_library config can be used without a name to configure the max file size for example.
See in
core/src/mediaLibrary.tstheisExternalMediaLibraryConfigfunction.